Skip to content

Forward unrecognized slash commands to Codex#281

Merged
benbrandt merged 1 commit into
agentclientprotocol:mainfrom
duclvz:fix/forward-unknown-slash-commands
Jul 13, 2026
Merged

Forward unrecognized slash commands to Codex#281
benbrandt merged 1 commit into
agentclientprotocol:mainfrom
duclvz:fix/forward-unknown-slash-commands

Conversation

@duclvz

@duclvz duclvz commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Pass slash commands not handled by the ACP adapter through as raw prompts, allowing Codex to resolve skills freely. Built-in commands continue to be handled locally.

Let Codex resolve slash commands that the adapter does not own.

@benbrandt benbrandt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexandrSuhinin Maybe you all had this this way for a reason? But I think this change seems reasonable

@AlexandrSuhinin

AlexandrSuhinin commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

@AlexandrSuhinin Maybe you all had this this way for a reason? But I think this change seems reasonable

We initially supported skills with the $ prefix: the same way they are supported in CLI.
Plus I believe that we want to have a completion for commands & skills in the clients. So acp implementation have to announce available options for this.
Also this is a way to advertise available commands.

But anyway I'm not against this change, probably it is still better than throwing an error.

@benbrandt

Copy link
Copy Markdown
Member

Yeah I am also not sure why this is needed to resolve skills (in the PR description that is the motivation...)
but I think this change is ok...

@benbrandt benbrandt merged commit 9c55411 into agentclientprotocol:main Jul 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants